Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: AsyncIO Integration [Part 2] #28

Merged
merged 4 commits into from Jun 2, 2020

Conversation

lidizheng
Copy link
Contributor

@lidizheng lidizheng commented May 18, 2020

Children PR of #26.

This PR includes AsyncIO version of:

  • Polling future
  • Page iterator

The AsyncIO version of polling future still uses the same mechanism as the sync version. The AsyncIO polling future tries to update its own state whenever the application want to access information or perform actions.

For page iterator, it has similar interface design as sync version. But instead of fulfilling normal generator protocol, it is based on the async generator.

Related #23

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 18, 2020
@lidizheng lidizheng changed the title AsyncIO Integration [Part 2] feat: AsyncIO Integration [Part 2] May 18, 2020
@lidizheng lidizheng force-pushed the aio-part-2 branch 2 times, most recently from 93a8cb8 to 41cf623 Compare May 18, 2020 21:54
@lidizheng lidizheng marked this pull request as ready for review May 18, 2020 22:11
docs/operation.rst Outdated Show resolved Hide resolved
google/api_core/operation_async.py Outdated Show resolved Hide resolved
google/api_core/operation_async.py Outdated Show resolved Hide resolved
google/api_core/future/async_future.py Show resolved Hide resolved
Copy link
Contributor Author

@lidizheng lidizheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@busunkim96 Thanks for reviewing! PTALA.

docs/operation.rst Outdated Show resolved Hide resolved
google/api_core/future/async_future.py Show resolved Hide resolved
google/api_core/operation_async.py Outdated Show resolved Hide resolved
google/api_core/operation_async.py Outdated Show resolved Hide resolved
* Polling future
* Page iterator
* With unit tests & docs
docs/operation.rst Outdated Show resolved Hide resolved
Co-authored-by: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Copy link
Contributor

@software-dov software-dov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, tests look good, just one minor commentary nit.

google/api_core/page_iterator_async.py Outdated Show resolved Hide resolved
@lidizheng
Copy link
Contributor Author

Thanks for reviewing 👍

@busunkim96 busunkim96 added the automerge Merge the pull request once unit tests and other checks pass. label Jun 2, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit dd9b2f3 into googleapis:master Jun 2, 2020
gcf-merge-on-green bot pushed a commit that referenced this pull request Jun 4, 2020
@busunkim96 busunkim96 mentioned this pull request Jun 17, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants