Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some libraries implicitly depend on pytz in google-api-core #250

Closed
busunkim96 opened this issue Aug 12, 2021 · 2 comments
Closed

Some libraries implicitly depend on pytz in google-api-core #250

busunkim96 opened this issue Aug 12, 2021 · 2 comments
Assignees
@busunkim96
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@busunkim96
Copy link
Contributor

busunkim96 commented Aug 12, 2021 •
edited

https://github.com/search?l=Python&p=2&q=org%3Agoogleapis+pytz+NOT+samples+NOT+tests&type=Code

pytz was dropped in a30f004 to resolve #73 (for the upcoming 2.0.0 release)

PR List:

googleapis/python-pubsub#472
googleapis/python-bigquery#875
googleapis/python-ndb#707
googleapis/python-runtimeconfig#78
googleapis/python-firestore#422 (optional)
@busunkim96 busunkim96 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Aug 12, 2021
This was referenced Aug 12, 2021
Merged
Merged
Merged
Merged
gcf-merge-on-green bot pushed a commit to googleapis/python-pubsub that referenced this issue Aug 13, 2021
@busunkim96
fix: remove dependency on pytz (#472)
972cc16 
For googleapis/python-api-core#250

Fixes #468.
@busunkim96
Copy link
Contributor Author

All linked PRs have been merged.

@busunkim96 busunkim96 self-assigned this Aug 17, 2021
@Gatsby-Lee
Copy link

@busunkim96 when are you going to deploy this change?

@EDjur EDjur mentioned this issue Aug 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@busunkim96 busunkim96

Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@busunkim96 @Gatsby-Lee