Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: retry google.auth TransportError and requests ConnectionError #178

Merged

Conversation

parthea
Copy link
Collaborator

@parthea parthea commented May 2, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #176 馃

@parthea parthea self-assigned this May 2, 2021
@parthea parthea requested a review from a team as a code owner May 2, 2021 10:21
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 2, 2021
@parthea parthea requested a review from busunkim96 May 2, 2021 10:21
Copy link
Contributor

@busunkim96 busunkim96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way for a bare requests.exception to make it to this code? I was under the impression the auth library would always wrap it.

Otherwise LGTM.

@parthea
Copy link
Collaborator Author

parthea commented May 3, 2021

@busunkim96 Here is an example of requests.exception in the stack trace in python-bigquery via googleapis/python-bigquery#434.

@parthea parthea added the automerge Merge the pull request once unit tests and other checks pass. label May 3, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 6ae04a8 into googleapis:master May 3, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

requests.exceptions.ConnectionError retry
2 participants