Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api-core): add client_cert_source to ClientOptions #17

Merged
merged 5 commits into from Apr 14, 2020
Merged

feat(api-core): add client_cert_source to ClientOptions #17

merged 5 commits into from Apr 14, 2020

Conversation

arithmetic1728
Copy link
Contributor

Fixes #16

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 30, 2020
busunkim96
busunkim96 reviewed Mar 31, 2020
View reviewed changes
Copy link
Contributor

@busunkim96 busunkim96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Do you have the bandwith in the next few weeks to add this to the generators? We'll have to coordinate releasing api-core and updating the client library dependencies.

google/api_core/client_options.py Outdated Show resolved Hide resolved
@arithmetic1728 @busunkim96
Update google/api_core/client_options.py
ca6c41c 
Co-Authored-By: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
@arithmetic1728
Copy link
Contributor Author

This looks good. Do you have the bandwith in the next few weeks to add this to the generators? We'll have to coordinate releasing api-core and updating the client library dependencies.

Yes, I am working on it right now.

@arithmetic1728 arithmetic1728 mentioned this pull request Apr 7, 2020
Closed
@arithmetic1728 arithmetic1728 merged commit 748c935 into master Apr 14, 2020
@arithmetic1728 arithmetic1728 deleted the sijun/cert branch April 14, 2020 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@busunkim96 busunkim96 busunkim96 approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add client_cert_source to ClientOptions
3 participants
@arithmetic1728 @busunkim96 @googlebot