Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add operation name to x-goog-request-params #133

Merged
merged 2 commits into from Jan 25, 2021
Merged

fix: add operation name to x-goog-request-params #133

merged 2 commits into from Jan 25, 2021

Conversation

busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Jan 19, 2021 •
edited

Add the routing header x-goog-request-params to operations client requests. Some APIs require that the header be passed on all requests.

Fixes googleapis/gapic-generator-python#732

@busunkim96 busunkim96 requested a review from a team as a code owner January 19, 2021 21:13
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 19, 2021
This was referenced Jan 19, 2021
Closed
Closed
software-dov
software-dov approved these changes Jan 25, 2021
View reviewed changes
Copy link
Contributor

@software-dov software-dov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some minor nitpicking.

google/api_core/operations_v1/operations_client.py Outdated Show resolved Hide resolved
google/api_core/operations_v1/operations_client.py Outdated Show resolved Hide resolved
google/api_core/operations_v1/operations_client.py Outdated Show resolved Hide resolved
google/api_core/operations_v1/operations_client.py Outdated Show resolved Hide resolved
@busunkim96 busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 25, 2021
@busunkim96 busunkim96 merged commit 97cef4a into master Jan 25, 2021
@busunkim96 busunkim96 deleted the add-operation-name branch January 25, 2021 19:49
@busunkim96 busunkim96 mentioned this pull request Jan 25, 2021
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Feb 12, 2021
@busunkim96
fix: add operation name to x-goog-request-params in async client (#137)
7271b23 
Pass the operation name in the `x-goog-request-params`header.
 
Same as #133 for the async operations client.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver approved these changes

@software-dov software-dov software-dov approved these changes

@turbaszek turbaszek turbaszek approved these changes

@alexander-fenster alexander-fenster Awaiting requested review from alexander-fenster

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. kokoro:force-run Add this label to force Kokoro to re-run the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Routing headers are not passed to the operations client
4 participants
@busunkim96 @tseaver @software-dov @turbaszek