Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: explain how to create credentials from dict #109

Merged
merged 3 commits into from Dec 14, 2020
Merged

docs: explain how to create credentials from dict #109

merged 3 commits into from Dec 14, 2020

Conversation

busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Dec 10, 2020 •
edited

  • Explain how to create service account from dictionary.
  • Add newer runtimes (Cloud Functions, Run)
  • Clarify that "App Engine credentials" are only for App Engine Standard Python 2.7
  • Link out to docs explaining service account key file creation
  • Link out to full list of scopes for APIs

For googleapis/google-cloud-python#7291

@busunkim96
docs: explain how to create credentials from dict
4796623 
* Explain how to create service account from dictionary.
* Add newer runtimes (Cloud Functions, Run)
* Clarify that App Engine credentials are only for Python 2.7
@busunkim96 busunkim96 requested a review from a team as a code owner December 10, 2020 16:19
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 10, 2020
tseaver
tseaver previously approved these changes Dec 10, 2020
View reviewed changes
tseaver
tseaver suggested changes Dec 10, 2020
View reviewed changes
docs/auth.rst
<img src="https://raw.githubusercontent.com/GoogleCloudPlatform/google-cloud-common/master/authentication/reuse-service-account.png">

.. _Google Developers Console: https://console.developers.google.com/project
.. _Google Developers Service Account: https://developers.google.com/accounts/docs/OAuth2ServiceAccount
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This target is still referenced above. See the failed docs build:

Warning, treated as error:
/tmpfs/src/github/python-api-core/docs/auth.rst:209:Unknown target name: "google developers service account".
nox > Command sphinx-build -W -T -N -b html -d docs/_build/doctrees/ docs/ docs/_build/html/ failed with exit code 2

@google-cla
Copy link

google-cla bot commented Dec 14, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Dec 14, 2020
@tseaver
Copy link
Contributor

tseaver commented Dec 14, 2020

@googlebot I consent.

@google-cla google-cla bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Dec 14, 2020
@tseaver tseaver added the automerge Merge the pull request once unit tests and other checks pass. label Dec 14, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 5dce6d6 into master Dec 14, 2020
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 14, 2020
@tseaver tseaver deleted the busunkim96-patch-1 branch December 14, 2020 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver approved these changes

@silvolu silvolu Awaiting requested review from silvolu

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@busunkim96 @tseaver