Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

docs: update region tag names to match the convention #55

Merged
merged 2 commits into from Mar 25, 2021

Conversation

ikuleshov
Copy link
Collaborator

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 馃

@ikuleshov ikuleshov requested a review from a team as a code owner March 25, 2021 07:51
@ikuleshov ikuleshov requested review from busunkim96 and removed request for a team March 25, 2021 07:51
@product-auto-label product-auto-label bot added the api: analyticsdata Issues related to the googleapis/python-analytics-data API. label Mar 25, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 25, 2021
@snippet-bot
Copy link

snippet-bot bot commented Mar 25, 2021

Here is the summary of possible violations 馃槺

There are 9 possible violations for not having product prefix.

The end of the violation section. All the stuff below is FYI purposes only.


Here is the summary of changes.

You are about to add 9 region tags.
You are about to delete 9 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@busunkim96
Copy link
Contributor

Snippet bot seems to indicate the prefix needs to be registered. The prefix is used to associate snippets to products. go/code-snippets-101 covers how to do that. (If the bot info is just out of date please disregard).

@busunkim96 busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 25, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 25, 2021
@ikuleshov ikuleshov merged commit 747f551 into googleapis:master Mar 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: analyticsdata Issues related to the googleapis/python-analytics-data API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants