Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Improve handling of undeploying model without redistributing remaining traffic #898

Merged
merged 6 commits into from Dec 16, 2021
Merged

fix: Improve handling of undeploying model without redistributing remaining traffic #898

merged 6 commits into from Dec 16, 2021

Conversation

vinnysenthil
Copy link
Contributor

  • Add informative error when undeploying a model with traffic from an Endpoint with multiple deployed models, without providing a new traffic split.
  • Improve accuracy of docstring for Endpoint.undeploy()
  • Add tests to cover CUJs

Fixes b/198290421 馃

@product-auto-label product-auto-label bot added the api: aiplatform Issues related to the AI Platform API. label Dec 8, 2021
@sasha-gitg sasha-gitg added the automerge Merge the pull request once unit tests and other checks pass. label Dec 16, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 8a8a4fa into main Dec 16, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the patch-traffic-split branch December 16, 2021 17:02
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sasha-gitg sasha-gitg sasha-gitg approved these changes

Assignees
No one assigned
Labels
api: aiplatform Issues related to the AI Platform API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vinnysenthil @sasha-gitg