Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add clarity to param model_name #888

Merged
merged 6 commits into from Dec 10, 2021
Merged

fix: add clarity to param model_name #888

merged 6 commits into from Dec 10, 2021

Conversation

andrewferlitsch
Copy link
Contributor

@andrewferlitsch andrewferlitsch commented Dec 6, 2021 •
edited

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 馃

@andrewferlitsch andrewferlitsch requested review from a team as code owners December 6, 2021 19:43
@product-auto-label product-auto-label bot added the api: aiplatform Issues related to the AI Platform API. label Dec 6, 2021
@vinnysenthil vinnysenthil added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 10, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 10, 2021
nicain
nicain approved these changes Dec 10, 2021
View reviewed changes
Copy link
Contributor

@nicain nicain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicain nicain added the automerge Merge the pull request once unit tests and other checks pass. label Dec 10, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 1d81783 into main Dec 10, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the issue_191647204 branch December 10, 2021 23:20
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicain nicain nicain approved these changes

@kweinmeister kweinmeister kweinmeister approved these changes

@loferris loferris Awaiting requested review from loferris loferris was automatically assigned from googleapis/python-samples-owners

Assignees
No one assigned
Labels
api: aiplatform Issues related to the AI Platform API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@andrewferlitsch @nicain @kweinmeister @vinnysenthil @yoshi-kokoro