Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add param for multi-label per user's feedback #887

Merged
merged 5 commits into from Dec 7, 2021
Merged

fix: add param for multi-label per user's feedback #887

merged 5 commits into from Dec 7, 2021

Conversation

andrewferlitsch
Copy link
Contributor

@andrewferlitsch andrewferlitsch commented Dec 6, 2021 •
edited by dandhlee

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 馃

@andrewferlitsch andrewferlitsch requested review from a team as code owners December 6, 2021 19:18
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 6, 2021
@product-auto-label product-auto-label bot added the api: aiplatform Issues related to the AI Platform API. label Dec 6, 2021
dandhlee
dandhlee approved these changes Dec 6, 2021
View reviewed changes
Copy link
Contributor

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andrewferlitsch andrewferlitsch merged commit fda942f into main Dec 7, 2021
@andrewferlitsch andrewferlitsch deleted the issue_207481307 branch December 7, 2021 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgandu morgandu morgandu approved these changes

@dandhlee dandhlee dandhlee approved these changes

Assignees
No one assigned
Labels
api: aiplatform Issues related to the AI Platform API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andrewferlitsch @morgandu @dandhlee