feat: add create in Featurestore, EntityType, Feature; add create_entity_type in Featurestore; add create_feature, batch_create_features in EntityType; add ingest_from_* for bq and gcs in EntityType; add and update delete with force delete nested resources #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
morgandu
commented
Dec 1, 2021
•
morgandu
commented
- add create method in Featurestore, EntityType, Feature classes;
- add create_entity_type in Featurestore;
- add create_feature, batch_create_features in EntityType;
- add ingest_from_bq and ingest_from_gcs methods in EntityType class
- add and update delete methods with force delete nested resources
- add unit tests
- update integration test
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: aiplatform
morgandu
force-pushed
the
mor--feature-store-create-and-ingest
branch
2 times, most recently
from
b9d6932
to
8af8486
Compare
morgandu
changed the title
morgandu
changed the title
morgandu
force-pushed
the
mor--feature-store-create-and-ingest
branch
4 times, most recently
from
f38cd2d
to
56d0db5
Compare
diemtvu
reviewed
Dec 2, 2021
morgandu
force-pushed
the
mor--feature-store-create-and-ingest
branch
from
56d0db5
to
9b1b72a
Compare
sasha-gitg
requested changes
Dec 6, 2021
morgandu
force-pushed
the
mor--feature-store-create-and-ingest
branch
from
9b1b72a
to
75ac97e
Compare
diemtvu
reviewed
Dec 10, 2021
morgandu
force-pushed
the
mor--feature-store-create-and-ingest
branch
2 times, most recently
from
41580d9
to
03aa950
Compare
sasha-gitg
requested changes
Dec 13, 2021
There was a problem hiding this comment.
One high level comment: if possible, please avoid force updating the commit history as some of the previous commits are no longer accessible and it becomes difficult to follow previous comments. It also seems to break "Show changes since last review" view. Thanks!
diemtvu
reviewed
Dec 13, 2021
diemtvu
approved these changes
Dec 16, 2021
… add create_entity_type in Featurestore; add create_feature, batch_create_features in EntityType; add ingest_from_bq and ingest_from_gcs methods in EntityType class
…hanging feature_config.request_dict to get_create_feature_request() with parent option
…irectly to api method; update docstring for feature_source_fields and node_count
…and feature_time for oneof, changed method validate_id to _is_resource_id, changed method validate_value_type to return None
…o setting for values if None; fix potential delete breaking change; change request_metadata to None and tests; update unit test for get_timestamp_proto; refactor feature_source_fields; remove optional batch_create from ingest and tests;
morgandu
force-pushed
the
mor--feature-store-create-and-ingest
branch
from
a5ab277
to
1e1c2fb
Compare
morgandu
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.