Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Upgrade Tensorboard from v1beta1 to v1 #849

Merged
merged 3 commits into from Nov 18, 2021
Merged

feat: Upgrade Tensorboard from v1beta1 to v1 #849

merged 3 commits into from Nov 18, 2021

Conversation

sasha-gitg
Copy link
Member

  • Added integration test for aiplatform.Tensorboard
  • b/206650730

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 17, 2021
@product-auto-label product-auto-label bot added the api: aiplatform Issues related to the AI Platform API. label Nov 17, 2021
morgandu
morgandu approved these changes Nov 17, 2021
View reviewed changes
Copy link
Contributor

@morgandu morgandu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes look good, only have a question on Mock fail.

tests/unit/aiplatform/test_custom_job.py
state=gca_job_state_compat.JobState.JOB_STATE_PENDING,
version="v1beta1",
)
create_custom_job_mock.side_effect = RuntimeError("Mock fail")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this "Mock fail" side effect for?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be git diff surfacing the change in a confusing way.

create_custom_job_mock_fail hasn't changed, reference line 263 on the previous version. It's used to test that we handle failure from the service.

create_custom_job_v1beta1_mock was changed to create_custom_job_mock_with_tensorboard above.

@sasha-gitg sasha-gitg merged commit c40ec85 into googleapis:main Nov 18, 2021
@yfang1 yfang1 mentioned this pull request Nov 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgandu morgandu morgandu approved these changes

@yfang1 yfang1 yfang1 approved these changes

Assignees
No one assigned
Labels
api: aiplatform Issues related to the AI Platform API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sasha-gitg @morgandu @yfang1