Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: default to custom job display name if experiment name looks like a custom job ID #833

Merged
merged 1 commit into from Nov 17, 2021

Conversation

yfang1
Copy link
Contributor

@yfang1 yfang1 commented Nov 8, 2021

The training backend doesn't store custom job display names, so the uploader would need to fetch the job display name on its own.

This allows experiments to be more recognizable in the Cloud Console experiment list UI.

b/203591169

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 8, 2021
@product-auto-label product-auto-label bot added the api: aiplatform Issues related to the AI Platform API. label Nov 8, 2021
@nicain
Copy link
Contributor

nicain commented Nov 8, 2021

@yfang1: I am assigning as owner of this PR; feel free to ping reviewers as needed to make sure the review process progresses in a timely fashion, or provide guidance on a who might better own the process of getting the PR reviewed, passing continuous testing, and merged. Reach out if you have questions.

Copy link
Member

@sasha-gitg sasha-gitg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Does this have a unit test that can be updated?

This mock can be copied/reused: https://github.com/googleapis/python-aiplatform/blob/main/tests/unit/aiplatform/test_custom_job.py#L147

@yfang1
Copy link
Contributor Author

yfang1 commented Nov 17, 2021

LGTM. Does this have a unit test that can be updated?

This mock can be copied/reused: https://github.com/googleapis/python-aiplatform/blob/main/tests/unit/aiplatform/test_custom_job.py#L147

Yes, I added new unit tests for the change.

@yfang1 yfang1 merged commit 8b9376e into googleapis:main Nov 17, 2021
@yfang1 yfang1 deleted the training branch November 17, 2021 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: aiplatform Issues related to the AI Platform API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants