Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exclude support for python 3.10 #831

Merged
merged 9 commits into from Nov 8, 2021
Merged

fix: exclude support for python 3.10 #831

merged 9 commits into from Nov 8, 2021

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Nov 8, 2021

PR #769 added support for python 3.10 however there are dependencies, like tensorflow in setup.py, which do not yet support python 3.10. As a result, we should revert the change in PR #769 that adds support for python 3.10.

@parthea parthea requested review from a team as code owners November 8, 2021 18:53
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 8, 2021
@product-auto-label product-auto-label bot added the api: aiplatform Issues related to the AI Platform API. label Nov 8, 2021
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 8, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 8, 2021
Copy link
Contributor

@nicain nicain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicain nicain merged commit 0301a1d into main Nov 8, 2021
@nicain nicain deleted the exclude-py310 branch November 8, 2021 23:36
@danielbick
Copy link

Hello, is there any plan already to get the support for Python 3.10 back?

@dandhlee
Copy link
Contributor

Hey @danielbick, in order to better facilitate the discussion, could you open an issue on this repo? Comments on closed / merged PRs can easily get lost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: aiplatform Issues related to the AI Platform API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants