Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use version.py for versioning #804

Merged
merged 1 commit into from Oct 29, 2021
Merged

fix: use version.py for versioning #804

merged 1 commit into from Oct 29, 2021

Conversation

sasha-gitg
Copy link
Member

@sasha-gitg sasha-gitg requested a review from a team as a code owner October 29, 2021 16:33
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 29, 2021
@product-auto-label product-auto-label bot added the api: aiplatform Issues related to the AI Platform API. label Oct 29, 2021
busunkim96
busunkim96 approved these changes Oct 29, 2021
View reviewed changes
Copy link
Contributor

@busunkim96 busunkim96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - https://github.com/googleapis/python-api-core/blob/main/setup.py uses this setup and this looks similar.

@sasha-gitg sasha-gitg merged commit 514031f into googleapis:main Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dizcology dizcology dizcology approved these changes

@busunkim96 busunkim96 busunkim96 approved these changes

@ji-yaqi ji-yaqi ji-yaqi approved these changes

Assignees
No one assigned
Labels
api: aiplatform Issues related to the AI Platform API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sasha-gitg @dizcology @busunkim96 @ji-yaqi