feat: support new protobuf value param types for Pipeline Job client #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: aiplatform
google-cla
bot
added
the
cla: yes
chensun
reviewed
Oct 27, 2021
| raise TypeError("Got unknown type of value: {}".format(value)) | ||
|
|
||
| return result | ||
| # 'parameters' are deprecated in IR and changed to 'parameterValues'. |
There was a problem hiding this comment.
nit: same here, try reading parameterValues first, then the old field as a fallback.
That would be more "efficient" going forward.
| parameter_types = {k: v["type"] for k, v in parameter_input_definitions.items()} | ||
| # 'type' is deprecated in IR and change to 'parameterType'. | ||
| parameter_types = { | ||
| k: v.get("type") or v.get("parameterType") |
There was a problem hiding this comment.
nit: usually we read the latest field first, and fallback to the deprecated field if the latest one not found.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: The test will be uncommented when GAPIC library change for protobuf values is complete.