Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: PipelineJob switch to v1 API from v1beta1 API #750

Merged
merged 13 commits into from Nov 2, 2021

Conversation

chensun
Copy link
Member

@chensun chensun commented Oct 5, 2021

No description provided.

@product-auto-label product-auto-label bot added the api: aiplatform Issues related to the AI Platform API. label Oct 5, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 5, 2021
@chensun chensun changed the title [Hold] PipelineJob switch to v1 API [Hold] chore: PipelineJob switch to v1 API Oct 5, 2021
@sasha-gitg sasha-gitg added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 5, 2021
@chensun
Copy link
Member Author

chensun commented Oct 6, 2021

/kokoro:force-run

@chensun chensun changed the title [Hold] chore: PipelineJob switch to v1 API chore: PipelineJob switch to v1 API Oct 6, 2021
@sasha-gitg sasha-gitg removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 1, 2021
@sasha-gitg sasha-gitg self-requested a review November 2, 2021 13:37
Copy link
Member

@sasha-gitg sasha-gitg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

There is one more level to expose the types as default types here:
https://github.com/googleapis/python-aiplatform/blob/main/google/cloud/aiplatform/compat/__init__.py

This allows importing without explicitly stating the API version which makes switching between versions during dev easier :

ie:

from google.cloud.compat.types import pipeline_job
from google.cloud.compat.types import pipeline_state

Won't block on this.

@sasha-gitg sasha-gitg changed the title chore: PipelineJob switch to v1 API feat: PipelineJob switch to v1 API from v1beta1 API Nov 2, 2021
@chensun
Copy link
Member Author

chensun commented Nov 2, 2021

LGTM.

There is one more level to expose the types as default types here: https://github.com/googleapis/python-aiplatform/blob/main/google/cloud/aiplatform/compat/__init__.py

This allows importing without explicitly stating the API version which makes switching between versions during dev easier :

ie:

from google.cloud.compat.types import pipeline_job
from google.cloud.compat.types import pipeline_state

Won't block on this.

Thanks! For the safety of the change, will do this next time if we switch version again.

@chensun chensun merged commit 8db7e0c into googleapis:main Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: aiplatform Issues related to the AI Platform API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants