fix(PipelineJob): use name as output only field #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: aiplatform
google-cla
bot
added
the
cla: yes
ivanmkc
approved these changes
Sep 20, 2021
| @@ -178,19 +175,18 @@ def __init__( | |||
| ) | |||
|
|
|||
| pipeline_name = pipeline_job["pipelineSpec"]["pipelineInfo"]["name"] | |||
| job_id = job_id or "{pipeline_name}-{timestamp}".format( | |||
| self.job_id = job_id or "{pipeline_name}-{timestamp}".format( | |||
There was a problem hiding this comment.
I know this is existing code, but why isn't there a way to get the job_id directly from the service instead of deriving it in the client SDK.
This seems like it could break if the service changes how job ID's are generated.
There was a problem hiding this comment.
I think job_id was provided by the user, or generated by the system and only used during run command but not the instance generation process. That's why we need to store it somewhere, since it wasn't used during the instance creation.
Name shouldn't be passed in since it was an output-only field and was wrongly passed in previously. Although the services generated the name using the same way.
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
create_timeis used to identify whether a job has been created. Now since we havejob_idfixed, we could leavenameout for output only and identify whether a job has been created usingname.