feat: code snippets for feature store control plane #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: aiplatform
|
Here is the summary of changes. You are about to add 4 region tags.
This comment is generated by snippet-bot.
|
lclc19
force-pushed
the
lclc_snippet
branch
from
5ce50af
to
cfc2ff9
Compare
morgandu
previously requested changes
Sep 15, 2021
samples/snippets/feature_store_service/create_entity_type_sample.py
Outdated
Show resolved
Hide resolved
samples/snippets/feature_store_service/delete_featurestore_sample.py
Outdated
Show resolved
Hide resolved
samples/snippets/feature_store_service/create_featurestore_sample_test.py
Show resolved
Hide resolved
samples/snippets/feature_store_service/create_entity_type_sample_test.py
Show resolved
Hide resolved
samples/snippets/feature_store_service/create_feature_sample_test.py
Outdated
Show resolved
Hide resolved
|
For delete sample, I see that dataset_service only has the sample file, and no test for delete sample was provided: I wonder if this is intentional as the teardown procedure already has the deletion snippets. |
lclc19
force-pushed
the
lclc_snippet
branch
3 times, most recently
from
678e868
to
0c84871
Compare
|
Anyways, I've added delete featurestore test |
lclc19
force-pushed
the
lclc_snippet
branch
from
0c84871
to
27a15d5
Compare
morgandu
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
* Add resource creation and deletion including featurestore, entity type and feature.
lclc19
force-pushed
the
lclc_snippet
branch
from
27a15d5
to
4d8e39d
Compare
lclc19
changed the title
lclc19
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
vinnysenthil
dismissed
morgandu’s stale review
morgandu@ is OOO and lclc@ has addressed all requested changes, lifting blocking review.
vinnysenthil
approved these changes
Sep 22, 2021
There was a problem hiding this comment.
LGTM - @morgandu's requested changes have been addressed, tests pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.