Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add wait_for_resource_creation to BatchPredictionJob and unblock async creation when model is pending creation. #660

Merged
merged 10 commits into from Aug 29, 2021

Conversation

sasha-gitg
Copy link
Member

@sasha-gitg sasha-gitg commented Aug 26, 2021

@sasha-gitg sasha-gitg requested a review from a team as a code owner August 26, 2021 20:22
@product-auto-label product-auto-label bot added the api: aiplatform Issues related to the AI Platform API. label Aug 26, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 26, 2021
gcs_destination_prefix='gs://path/to/by/batch_prediction/results/'
)

You can also create a batch prediction job asynchronously by including the `sync=False` argument:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this line be part of the code block?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not intended to be in the code block.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant to say that it might be better to move it after the .. code-block:: Python line.

Copy link
Contributor

@ivanmkc ivanmkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Which bug is this for?

@sasha-gitg
Copy link
Member Author

Thanks Ivan! I updated the PR with the ticket references.

@sasha-gitg sasha-gitg merged commit db580ad into googleapis:main Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: aiplatform Issues related to the AI Platform API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BatchPredictionJob : sync=False and wait_for_resource_creation()
3 participants