Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: split GAPIC samples by service #599

Merged
merged 8 commits into from Aug 13, 2021
Merged

feat: split GAPIC samples by service #599

merged 8 commits into from Aug 13, 2021

Conversation

dizcology
Copy link
Contributor

No description provided.

@dizcology dizcology requested review from a team as code owners August 9, 2021 18:14
@dizcology dizcology requested a review from parthea August 9, 2021 18:15
@product-auto-label product-auto-label bot added api: aiplatform Issues related to the AI Platform API. samples Issues that are directly related to samples. labels Aug 9, 2021
@dizcology dizcology added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 9, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 9, 2021
@snippet-bot
Copy link

snippet-bot bot commented Aug 9, 2021 •
edited

Here is the summary of possible violations 😱

There are 30 possible violations for removing region tag in use.

The end of the violation section. All the stuff below is FYI purposes only.

Here is the summary of changes.

You are about to add 98 region tags.
You are about to delete 98 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@dizcology dizcology added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 12, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 12, 2021
@dizcology dizcology added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 12, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 12, 2021
vinnysenthil
vinnysenthil approved these changes Aug 12, 2021
View reviewed changes
Copy link
Contributor

@vinnysenthil vinnysenthil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for splitting this up

@dizcology dizcology added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 12, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 12, 2021
@dizcology dizcology removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 13, 2021
@dizcology dizcology merged commit 5f15b4f into googleapis:master Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinnysenthil vinnysenthil vinnysenthil approved these changes

@parthea parthea Awaiting requested review from parthea

Assignees
No one assigned
Labels
api: aiplatform Issues related to the AI Platform API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dizcology @vinnysenthil @yoshi-kokoro