Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed the column name corruption bug in TabularDataset.column_names #590

Merged
merged 3 commits into from Aug 4, 2021

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Aug 3, 2021

The end parameter of the blob.download_as_bytes function is inclusive, not exclusive.

Fixes #589

There are 2 hard problems in computer science: cache invalidation, naming things, and off-by-1 errors.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #589

Fixes googleapis#589

The `end` parameter of the `blob.download_as_bytes` function is inclusive, not exclusive.

> There are 2 hard problems in computer science: cache invalidation, naming things, and off-by-1 errors.
@Ark-kun Ark-kun requested a review from a team as a code owner August 3, 2021 06:18
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 3, 2021
@product-auto-label product-auto-label bot added the api: aiplatform Issues related to the AI Platform API. label Aug 3, 2021
Ark-kun added a commit to Ark-kun/pipeline_components that referenced this pull request Aug 3, 2021
Ark-kun added a commit to Ark-kun/pipeline_components that referenced this pull request Aug 3, 2021
@sasha-gitg sasha-gitg requested a review from ivanmkc August 3, 2021 15:37
Copy link
Member

@sasha-gitg sasha-gitg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks Alexey!

@sasha-gitg sasha-gitg added the automerge Merge the pull request once unit tests and other checks pass. label Aug 3, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 4, 2021
Copy link
Contributor

@ivanmkc ivanmkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sasha-gitg sasha-gitg merged commit 0fbcd59 into googleapis:master Aug 4, 2021
Ark-kun added a commit to Ark-kun/pipeline_components that referenced this pull request Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: aiplatform Issues related to the AI Platform API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weird bug in TabularDataset.column_names
3 participants