feat: add wait for creation and more informative exception when properties are not available #566
Conversation
product-auto-label
bot
added
the
api: aiplatform
google-cla
bot
added
the
cla: yes
| @@ -255,6 +255,8 @@ def get_model_with_custom_project_mock(): | |||
| get_model_mock.return_value = gca_model.Model( | |||
| display_name=_TEST_MODEL_NAME, | |||
| name=_TEST_MODEL_RESOURCE_NAME_CUSTOM_PROJECT, | |||
| artifact_uri=_TEST_ARTIFACT_URI, | |||
| description=_TEST_DESCRIPTION, | |||
There was a problem hiding this comment.
I presume these are being added to ensure that accessing these fields will still raise a RuntimeError if _gca_resource is not set?
There was a problem hiding this comment.
These fields were added to test properties would return without throwing a RuntimeError if gca_resource is set, though these tests could have asserted for empty strings per underlying proto implementation so this may not be necessary.
| while not getattr(self._gca_resource, "name", None): | ||
| # breaks out of loop if creation has failed async | ||
| if self._are_futures_done() and not getattr( | ||
| self._gca_resource, "name", None | ||
| ): | ||
| self._raise_future_exception() | ||
|
|
||
| time.sleep(1) |
There was a problem hiding this comment.
Is this frequency of polling alright? Since it doesn't call the service I'm presuming so.
There was a problem hiding this comment.
Correct, it doesn't call the service. Also, when in this loop there is no _gca_resource available so the resource either hasn't been created yet or our creation request hasn't returned yet.
Includes fixes to some properties.