Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tensorboard resource management #539

Merged

Conversation

morgandu
Copy link
Contributor

  • add Tensorboard class for resource management
  • Ensure the tests and linter pass

Fixes #<b/190835588> 🦕

@morgandu morgandu requested a review from a team as a code owner July 13, 2021 18:23
@product-auto-label product-auto-label bot added the api: aiplatform Issues related to the AI Platform API. label Jul 13, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 13, 2021
@morgandu morgandu force-pushed the mor--tensorboard-resource-management branch from e9d6589 to 3235726 Compare July 13, 2021 22:45
@morgandu morgandu requested a review from sasha-gitg July 14, 2021 00:44
@morgandu morgandu force-pushed the mor--tensorboard-resource-management branch from 3235726 to d34b8ba Compare July 14, 2021 18:00
google/cloud/aiplatform/__init__.py Outdated Show resolved Hide resolved
google/cloud/aiplatform/tensorboard/tensorboard.py Outdated Show resolved Hide resolved
google/cloud/aiplatform/tensorboard/tensorboard.py Outdated Show resolved Hide resolved
google/cloud/aiplatform/tensorboard/tensorboard.py Outdated Show resolved Hide resolved
google/cloud/aiplatform/tensorboard/tensorboard.py Outdated Show resolved Hide resolved
google/cloud/aiplatform/tensorboard/tensorboard.py Outdated Show resolved Hide resolved
google/cloud/aiplatform/tensorboard/tensorboard.py Outdated Show resolved Hide resolved
tests/unit/aiplatform/test_tensorboard.py Show resolved Hide resolved
tests/unit/aiplatform/test_tensorboard.py Outdated Show resolved Hide resolved
@morgandu morgandu force-pushed the mor--tensorboard-resource-management branch from d34b8ba to c139c1c Compare July 16, 2021 19:17
@morgandu morgandu requested a review from sasha-gitg July 16, 2021 19:19
Copy link
Member

@sasha-gitg sasha-gitg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, Morgan!

The name can be up to 128 characters long and can be consist
of any UTF-8 characters.
description (str):
Optional description of this Tensorboard.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format should be Optional. Description of this Tensorboard. Please apply throughout this PR.

@morgandu morgandu added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 20, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 20, 2021
@morgandu morgandu merged commit 6f8d3d1 into googleapis:master Jul 21, 2021
@morgandu morgandu deleted the mor--tensorboard-resource-management branch July 21, 2021 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: aiplatform Issues related to the AI Platform API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants