Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ds.column_names doesn't contain nested fields in BigQuery table #504

Closed
geraint0923 opened this issue Jun 23, 2021 · 2 comments
Closed

ds.column_names doesn't contain nested fields in BigQuery table #504

geraint0923 opened this issue Jun 23, 2021 · 2 comments
Assignees
@ivanmkc @sirtorry
Labels
api: aiplatform Issues related to the AI Platform API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@geraint0923
Copy link
Contributor

python-aiplatform/google/cloud/aiplatform/datasets/tabular_dataset.py

Line 207 in d0f229d

return [schema.name for schema in schema]

This only returns the outer field names, and the nested fields are ignored.
@product-auto-label product-auto-label bot added the api: aiplatform Issues related to the AI Platform API. label Jun 23, 2021
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Jun 24, 2021
@sirtorry sirtorry added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. and removed triage me I really want to be triaged. labels Jun 28, 2021
@ivanmkc
Copy link
Contributor

ivanmkc commented Jun 28, 2021

Thanks for flagging this.

@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Jun 30, 2021
@sirtorry
Copy link
Contributor

fixed in #522

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivanmkc ivanmkc

@sirtorry sirtorry

Labels
api: aiplatform Issues related to the AI Platform API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@geraint0923 @ivanmkc @sirtorry @yoshi-automation