New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add cancel method to pipeline client #488
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
@@ -264,7 +264,7 @@ def state(self) -> Optional[gca_pipeline_state_v1beta1.PipelineState]: | |||
@property | |||
def _has_run(self) -> bool: | |||
"""Helper property to check if this pipeline job has been run.""" | |||
return bool(self._gca_resource.name) | |||
return bool(self._gca_resource.create_time) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the motivation for relying on create_time
? I wonder if we should use it elsewhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For Pipeline Job, name is created by us from the SDK side, so it will exist even if we don't start the run. (Compared to other jobs, their names are created from the BE)
The Kokoro doc presubmit error is tracked in: googleapis/sphinx-docfx-yaml#47 |
No description provided.