Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove URI attribute from Endpoint sample #478

Merged
merged 1 commit into from Jun 16, 2021
Merged

fix: Remove URI attribute from Endpoint sample #478

merged 1 commit into from Jun 16, 2021

Conversation

aribray
Copy link
Contributor

@aribray aribray commented Jun 14, 2021

Remove the endpoint.uri attribute from create_endpoint_sample.py.

Resolves Buganizer issue

Fixes #189844848馃

@aribray aribray requested review from a team as code owners June 14, 2021 19:59
@aribray aribray requested review from crwilcox and removed request for a team June 14, 2021 19:59
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 14, 2021
@product-auto-label product-auto-label bot added api: aiplatform Issues related to the AI Platform API. samples Issues that are directly related to samples. labels Jun 14, 2021
@aribray aribray force-pushed the aribray--fix-endpoint-sample branch from 767e110 to 961d9b5 Compare June 14, 2021 20:02
ivanmkc
ivanmkc approved these changes Jun 15, 2021
View reviewed changes
Copy link
Contributor

@ivanmkc ivanmkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aribray aribray added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 15, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 15, 2021
@parthea parthea added the automerge Merge the pull request once unit tests and other checks pass. label Jun 16, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit e3cbdd8 into googleapis:master Jun 16, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanmkc ivanmkc ivanmkc approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
api: aiplatform Issues related to the AI Platform API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aribray @ivanmkc @parthea @yoshi-kokoro