Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: column specs for tabular transformation #466

Merged
merged 23 commits into from Jul 15, 2021
Merged

feat: column specs for tabular transformation #466

merged 23 commits into from Jul 15, 2021

Conversation

sirtorry
Copy link
Contributor

@sirtorry sirtorry commented Jun 8, 2021 •
edited

  • adds column_specs as an alternative to column_transformation
  • adds training_jobs.AutoMLTabularTrainingJob.get_auto_column_specs
  • adds aiplatform.column

@sirtorry sirtorry requested a review from ivanmkc June 8, 2021 20:04
@sirtorry sirtorry requested a review from a team as a code owner June 8, 2021 20:04
@product-auto-label product-auto-label bot added the api: aiplatform Issues related to the AI Platform API. label Jun 8, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 8, 2021
@sirtorry sirtorry changed the title [WIP] tabular transformation feature feat: column specs for tabular transformation Jun 15, 2021
ivanmkc
ivanmkc suggested changes Jun 16, 2021
View reviewed changes
Copy link
Contributor

@ivanmkc ivanmkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comments

google/cloud/aiplatform/datasets/time_series_dataset.py Outdated Show resolved Hide resolved
google/cloud/aiplatform/training_jobs.py Show resolved Hide resolved
google/cloud/aiplatform/training_jobs.py Outdated Show resolved Hide resolved
google/cloud/aiplatform/training_jobs.py Show resolved Hide resolved
google/cloud/aiplatform/training_jobs.py Outdated Show resolved Hide resolved
tests/unit/aiplatform/test_automl_tabular_training_jobs.py Outdated Show resolved Hide resolved
google/cloud/aiplatform/training_jobs.py Outdated Show resolved Hide resolved
google/cloud/aiplatform/column.py Outdated Show resolved Hide resolved
sasha-gitg
sasha-gitg requested changes Jun 21, 2021
View reviewed changes
google/cloud/aiplatform/datasets/time_series_dataset.py Outdated Show resolved Hide resolved
google/cloud/aiplatform/training_jobs.py Outdated Show resolved Hide resolved
google/cloud/aiplatform/training_jobs.py Outdated Show resolved Hide resolved
google/cloud/aiplatform/training_jobs.py Outdated Show resolved Hide resolved
google/cloud/aiplatform/training_jobs.py Outdated Show resolved Hide resolved
google/cloud/aiplatform/training_jobs.py Show resolved Hide resolved
google/cloud/aiplatform/training_jobs.py Outdated Show resolved Hide resolved
tests/unit/aiplatform/test_automl_tabular_training_jobs.py Outdated Show resolved Hide resolved
google/cloud/aiplatform/training_jobs.py Show resolved Hide resolved
google/cloud/aiplatform/__init__.py Outdated Show resolved Hide resolved
@sirtorry sirtorry requested review from ivanmkc and sasha-gitg and removed request for vinnysenthil July 10, 2021 18:31
sasha-gitg
sasha-gitg requested changes Jul 13, 2021
View reviewed changes
google/cloud/aiplatform/training_jobs.py Show resolved Hide resolved
google/cloud/aiplatform/training_jobs.py Outdated Show resolved Hide resolved
google/cloud/aiplatform/training_jobs.py Outdated Show resolved Hide resolved
google/cloud/aiplatform/training_jobs.py Outdated Show resolved Hide resolved
sasha-gitg
sasha-gitg approved these changes Jul 15, 2021
View reviewed changes
Copy link
Member

@sasha-gitg sasha-gitg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly LGTM. One more comment it seems I didn't include in the last review. Thanks!

google/cloud/aiplatform/training_jobs.py Outdated Show resolved Hide resolved
ivanmkc
ivanmkc approved these changes Jul 15, 2021
View reviewed changes
Copy link
Contributor

@ivanmkc ivanmkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after Sasha's suggestion

@ivanmkc
Copy link
Contributor

ivanmkc commented Jul 15, 2021

What about the deprecation warning for column_transformations?

@sirtorry sirtorry added the automerge Merge the pull request once unit tests and other checks pass. label Jul 15, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 71d0bd4 into googleapis:master Jul 15, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 15, 2021
@sirtorry sirtorry deleted the tabular_transformations branch July 15, 2021 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanmkc ivanmkc ivanmkc approved these changes

@sasha-gitg sasha-gitg sasha-gitg approved these changes

Assignees
No one assigned
Labels
api: aiplatform Issues related to the AI Platform API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sirtorry @ivanmkc @sasha-gitg