Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tb-gcp-uploader to show flags in "--help" correctly, and new flags for api uri overriding #409

Merged
merged 2 commits into from May 19, 2021

Conversation

yfang1
Copy link
Contributor

@yfang1 yfang1 commented May 19, 2021

  • Plumbing the flags from uploader_main to main such that "tb-gcp-uploader --help" will show flag definitions
  • defining new flags for api and web server uri, to allow for communicating with non-prod APIs

@yfang1 yfang1 requested a review from a team as a code owner May 19, 2021 06:55
@google-cla
Copy link

google-cla bot commented May 19, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no This human has *not* signed the Contributor License Agreement. label May 19, 2021
@product-auto-label product-auto-label bot added the api: aiplatform Issues related to the AI Platform API. label May 19, 2021
@google-cla google-cla bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels May 19, 2021
@sasha-gitg sasha-gitg merged commit 9f603dd into googleapis:master May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: aiplatform Issues related to the AI Platform API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants