New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add custom and hp tuning #388
feat: add custom and hp tuning #388
Conversation
…g pipelines to use snake case instead of camel case to be consistent with custom job
…e as a separate package
…ers, will follow up to add them in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for getting this in time for the release 👏🏽
Just a few nits and a requested change around search_algorithms
.
- Code review
- Successful manual test of HPT
- Successful manual test of CustomJob
@property | ||
def gca_resource(self) -> proto.Message: | ||
"""The underlying resource proto represenation.""" | ||
return self._gca_resource |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we exposing this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Customers may need a field we haven't exposed. This allows us to provide code that doesn't require referencing a private attribute.
Co-authored-by: Vinny Senthil <vinnysenthil@gmail.com>
Co-authored-by: Vinny Senthil <vinnysenthil@gmail.com>
Co-authored-by: Vinny Senthil <vinnysenthil@gmail.com>
Co-authored-by: Vinny Senthil <vinnysenthil@gmail.com>
Co-authored-by: Vinny Senthil <vinnysenthil@gmail.com>
Co-authored-by: Vinny Senthil <vinnysenthil@gmail.com>
Co-authored-by: Vinny Senthil <vinnysenthil@gmail.com>
Co-authored-by: Vinny Senthil <vinnysenthil@gmail.com>
Co-authored-by: Vinny Senthil <vinnysenthil@gmail.com>
Thanks for the awesome review Vinny! |
No description provided.