Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add VPC Peering support to CustomTrainingJob classes #378

Merged
merged 2 commits into from May 12, 2021

Conversation

vinnysenthil
Copy link
Contributor

Exposes the network parameter in CustomTrainingJob.run() and subclasses to allow user to peer Job to a GCE network.

Fixes b/186368472 馃

@product-auto-label product-auto-label bot added the api: aiplatform Issues related to the AI Platform API. label May 10, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 10, 2021
Copy link
Member

@sasha-gitg sasha-gitg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please hold until v0.8 is released.

@vinnysenthil vinnysenthil added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels May 10, 2021
@vinnysenthil vinnysenthil merged commit 56273f7 into master May 12, 2021
@vinnysenthil vinnysenthil deleted the vpc-peering branch May 12, 2021 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: aiplatform Issues related to the AI Platform API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants