Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds enhanced protos for time series forecasting #374

Merged
merged 7 commits into from Jun 2, 2021

Conversation

parthea
Copy link
Contributor

@parthea parthea commented May 10, 2021

This PR migrates from autosynth to owl bot. owl bot will save time for maintainers as it will automatically open PRs when there are updates in googleapis-gen without requiring maintainers to run synthtool to build the client from protos. Additionally, similar to autosynth, PRs will be automatically opened when there are template updates.

Googlers see here.

This PR also pulls in the latest API changes from googleapis-gen and synthtool templates.

This PR includes the following features/fixes/doc updates.

chore: migrate to owl bot
docs: removes tinyurl links
docs: changes product name to Vertex AI
docs: correct link to fieldmask
feat: adds enhanced protos for time series forecasting
fix: remove display_name from FeatureStore
feat: add invalid_row_count to ImportFeatureValuesResponse and ImportFeatureValuesOperationMetadata
feat: add featurestore, index, metadata, monitoring, pipeline, and tensorboard services to aiplatform v1beta1
fix: configuring timeouts for aiplatform v1 methods
feat: remove unsupported accelerator types
feat: add aiplatform API Vizier service
feat: removes forecasting (time_series_forecasting proto) from public v1beta1 protos
chore: updates copyright on schema/ protos
chore: updates prediction and training proto files to v1beta1 AI Platform client libraries.
feat: removes unused protos from schema/ folders: schema/io_format.proto, schema/saved_query_metadata.proto
feat: ImageSegmentationPredictionResult.category_mask field changed to string data type
feat: AutoMlImageSegmentationInputs.ModelType adds MOBILE_TF_LOW_LATENCY constant
feat: AutoMlVideoClassificationInputs.ModelType adds MOBILE_JETSON_VERSATILE_1 constant
fix: add async client to %name_%version/init.py
chore: add autogenerated snippets
chore: remove auth, policy, and options from the reserved names list
feat: support self-signed JWT flow for service accounts
chore: enable GAPIC metadata generation
chore: sort subpackages in %namespace/%name/init.py

@parthea parthea added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 10, 2021
@parthea parthea requested review from a team as code owners May 10, 2021 01:17
@product-auto-label product-auto-label bot added the api: aiplatform Issues related to the AI Platform API. label May 10, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 10, 2021
@busunkim96
Copy link
Contributor

This repository maintains long-running development branches. Will it be easier to apply this change to move some other branch to owlbot first?

@vinnysenthil could you advise us on the best course of action? Thanks!

go/owlbot-howto explains Owl Bot which is replacing synth.py/Autosynth.

@parthea
Copy link
Contributor Author

parthea commented Jun 1, 2021

@aribray Please take a look at the conventional commit messages in the PR body to check whether any of the changes should be considered breaking.

@parthea parthea changed the title chore: migrate to owl bot feat: adds enhanced protos for time series forecasting Jun 1, 2021
@busunkim96
Copy link
Contributor

@parthea Are any those breaking changes in the v1beta1? I think the ! should be dropped from those messages to avoid creating a 2.0.0 release.

@parthea parthea added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 2, 2021
@parthea
Copy link
Contributor Author

parthea commented Jun 2, 2021

@busunkim96 I have a concern that some changes in v1 might be breaking. For example, see https://github.com/googleapis/googleapis-gen/commit/2ccb81a5a98312aa585b46fc6264ad2d64685c24#diff-f05c030e331b4418a0a9bb9d3cd01d22be4aceab3db18aec1d9660059d590ae0R1592 where a test was changed.

It looks like nodejs-ai-platform acknowledged the breaking change in the changelog but did not bump the major version in the next release 1.7.0.

I'd like to hand this over to @aribray and @telpirion to take a look at the history for aiplatform v1 since February 5th and determine how to proceed (whether to mark the changes as breaking but not bump the major version). The reason that the date is February 5th, 2021 is because of the sha in synth.metadata here .

@parthea
Copy link
Contributor Author

parthea commented Jun 2, 2021

After digging into the CL with the breaking change, there is messaging that suggests the changes should not be breaking so everything looks good on my end. I'll remove the exclamation point ! and merge.

@parthea parthea added automerge Merge the pull request once unit tests and other checks pass. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Jun 2, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit fdc968f into master Jun 2, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the owl-bot branch June 2, 2021 10:04
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: aiplatform Issues related to the AI Platform API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants