Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add service account support to Custom Training and Model deployment #342

Merged
merged 4 commits into from Apr 20, 2021
Merged

feat: Add service account support to Custom Training and Model deployment #342

merged 4 commits into from Apr 20, 2021

Conversation

vinnysenthil
Copy link
Contributor

Summary of Changes

  • Add service_account parameter to run() method of the three Custom Training classes
  • Add service_account parameter to deploy() in Endpoint and Model
  • Update tests to get coverage in each class that was modified

Fixes b/183951295 馃

@product-auto-label product-auto-label bot added the api: aiplatform Issues related to the AI Platform API. label Apr 20, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 20, 2021
sasha-gitg
sasha-gitg approved these changes Apr 20, 2021
View reviewed changes
Copy link
Member

@sasha-gitg sasha-gitg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Vinny!

@sasha-gitg sasha-gitg merged commit b4b1b12 into master Apr 20, 2021
@sasha-gitg sasha-gitg deleted the sa-custom-task branch April 20, 2021 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sasha-gitg sasha-gitg sasha-gitg approved these changes

Assignees
No one assigned
Labels
api: aiplatform Issues related to the AI Platform API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vinnysenthil @sasha-gitg