Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: MBSDK Tabular samples #338

Merged
merged 16 commits into from Apr 30, 2021
Merged

Conversation

aribray
Copy link
Contributor

@aribray aribray commented Apr 19, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Tracking Bug: MB SDK Samples - Milestone 1

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@aribray aribray requested review from dizcology and a team as code owners April 19, 2021 18:00
@aribray aribray requested review from leahecole and removed request for a team April 19, 2021 18:00
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 19, 2021
@product-auto-label product-auto-label bot added api: aiplatform Issues related to the AI Platform API. samples Issues that are directly related to samples. labels Apr 19, 2021
@snippet-bot
Copy link

snippet-bot bot commented Apr 19, 2021

Here is the summary of changes.

You are about to add 7 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@aribray aribray changed the base branch from master to dev April 19, 2021 18:00
@aribray aribray changed the title MBSDK Tabular samples feat: MBSDK Tabular samples Apr 19, 2021
@vinnysenthil vinnysenthil requested review from sasha-gitg and removed request for leahecole April 21, 2021 16:07
@aribray aribray added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 21, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 21, 2021
@aribray aribray requested a review from sasha-gitg April 21, 2021 22:01
@aribray aribray self-assigned this Apr 23, 2021
@vinnysenthil vinnysenthil self-requested a review April 30, 2021 06:12
@google-cla
Copy link

google-cla bot commented Apr 30, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Apr 30, 2021
@vinnysenthil
Copy link
Contributor

@googlebot I consent.

@google-cla google-cla bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Apr 30, 2021
@vinnysenthil vinnysenthil changed the base branch from dev to master April 30, 2021 16:58
@aribray aribray requested a review from a team as a code owner April 30, 2021 17:45
@vinnysenthil vinnysenthil added the automerge Merge the pull request once unit tests and other checks pass. label Apr 30, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 4241738 into master Apr 30, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the aribray--mbsdk-tabular branch April 30, 2021 18:04
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: aiplatform Issues related to the AI Platform API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants