fix: make logging more informative during training #310
Conversation
product-auto-label
bot
added
the
api: aiplatform
google-cla
bot
added
the
cla: yes
| time.sleep(wait) | ||
|
|
||
| self._raise_failure() | ||
|
|
||
| _LOGGER.log_action_completed_against_resource("", "run", self) | ||
| _LOGGER.log_action_completed_against_resource("run", "completed", self) |
There was a problem hiding this comment.
From the docstring of log_action_completed_against_resource, which is:
Args:
noun (str): Noun the action acts on against the resource. Can be empty string.
action (str): Action started against resource. ie: "Deployed". Can be empty string.
resource_noun_obj (AiPlatformResourceNoun):
Resource noun object the action is acting against
I can't tell if these args are correct or not.
What does Noun the action acts on against the resource. mean?
There was a problem hiding this comment.
The noun-action combo is for nouns in the following:
- run completed
- data imported
- model deployed
Sometimes these nouns are separate from the resource they act on. Like data/dataset and model/endpoint. Happy to improve the wording in the comment.
There was a problem hiding this comment.
Okay I see!
I was having trouble parsing the sentence. I get it now.
Perhaps could be changed to:
The noun that the action acts on against the resource.,
The action that was started against the resource., etc.
The examples would actually be the most helpful.
| @@ -646,12 +646,12 @@ def _block_until_complete(self): | |||
| ) | |||
| ) | |||
| log_wait = min(log_wait * multiplier, max_wait) | |||
| previous_time = current_time | |||
No description provided.