Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for multiple client versions, change aiplatform from compat.V1BETA1 to compat.V1 #290

Merged
merged 4 commits into from Apr 7, 2021

Conversation

morgandu
Copy link
Contributor

@morgandu morgandu commented Apr 6, 2021

  • add compat module
  • centralize types and servcies (client) in compat for V1 and V1BETA1
  • update all types in google.cloud.aiplatform modules to point to compat.types
  • update all services (client) in google.cloud.aiplatform modules to point to compat.services
  • In utils.py
  • change the WrappedClient to an abstract ClientWithOverride class
  • add (Service)ClientWithOverride for each AiPlatformService to predefine _default_version and _version_map
  • add a TypeVar AiPlatformServiceClientWithOverride, and update TypeVar AiPlatformServiceClient
  • In initializer.py
  • add select_version to get_encryption_spec
  • In each AiPlatformResourceNoun class
  • change client_class to (Service)ClientWithOverride
  • In BatchPredictionJob, Endpoint, and Model class
  • add client version selection logic
  • unit tests
  • update existing tests to make sure all tests pass
  • add unit tests to make sure AiPlatformServiceClientWithOverride works for V1BETA1 and V1
  • point all types and services in tests.unit.aiplatform to V1
  • add fixtures to support V1BETA1 tests for explanation related functionality
  • make sure all tests pass (merging from fix: add v1 conversion value rule)

Fixes b/180711319 🦕

@morgandu morgandu requested review from dizcology and a team as code owners April 6, 2021 17:30
@morgandu morgandu requested review from kurtisvg and removed request for a team April 6, 2021 17:30
@snippet-bot
Copy link

snippet-bot bot commented Apr 6, 2021

Here is the summary of changes.

You are about to add 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@morgandu morgandu changed the base branch from master to dev April 6, 2021 17:31
@morgandu morgandu requested review from vinnysenthil and sasha-gitg and removed request for dizcology and kurtisvg April 6, 2021 17:31
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 6, 2021
@morgandu morgandu changed the title Change aiplatform from compat.V1BETA1 to compat.V1 feat: change aiplatform from compat.V1BETA1 to compat.V1 Apr 6, 2021
Copy link
Member

@sasha-gitg sasha-gitg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thank you for all the hard work!

(FYI, need to run blacken for linting to pass)

@morgandu morgandu changed the title feat: change aiplatform from compat.V1BETA1 to compat.V1 feat: add support for multiple client versions, change aiplatform from compat.V1BETA1 to compat.V1 Apr 7, 2021
@morgandu morgandu merged commit 89e3212 into googleapis:dev Apr 7, 2021
@morgandu morgandu deleted the mor--compat-v1 branch April 7, 2021 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants