Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Custom Container Prediction support, move to single API endpoint #277

Merged
merged 4 commits into from Mar 31, 2021

Conversation

vinnysenthil
Copy link
Contributor

Summary of Changes

  • Make artifact_uri optional in Model.upload() to allow for custom containers that contain model artifacts & server
  • Remove reference to specific prediction endpoint (*-prediction-aiplatform.googleapis.com) - link to commit
  • Update relevant tests

Fixes b/184049758, b/180036930 馃

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 31, 2021
Copy link
Member

@sasha-gitg sasha-gitg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

google/cloud/aiplatform/models.py Outdated Show resolved Hide resolved
@vinnysenthil vinnysenthil added the automerge Merge the pull request once unit tests and other checks pass. label Mar 31, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit ca7f6d6 into dev Mar 31, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the mb-custom-prediction branch March 31, 2021 15:36
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants