From 56285ae14f53ed3cfca5c78b25f75895e98a5a36 Mon Sep 17 00:00:00 2001 From: Morgan Du Date: Wed, 24 Nov 2021 16:31:57 -0800 Subject: [PATCH] add integration test --- tests/system/aiplatform/test_featurestore.py | 17 +++++------------ tests/unit/aiplatform/test_featurestores.py | 2 +- 2 files changed, 6 insertions(+), 13 deletions(-) diff --git a/tests/system/aiplatform/test_featurestore.py b/tests/system/aiplatform/test_featurestore.py index ce87e7f053..2d3d3e7f19 100644 --- a/tests/system/aiplatform/test_featurestore.py +++ b/tests/system/aiplatform/test_featurestore.py @@ -16,6 +16,7 @@ # from google.cloud import aiplatform +from google.cloud.aiplatform import _featurestores as featurestores from tests.system.aiplatform import e2e_base @@ -29,16 +30,8 @@ def test_create_and_get_featurestore(self, shared_state): project=e2e_base._PROJECT, location=e2e_base._LOCATION, ) - display_name = self._make_display_name("tensorboard") + list_featurestores = featurestores.Featurestore.list() + assert len(list_featurestores) >= 0 - tb = aiplatform.Tensorboard.create(display_name=display_name) - - shared_state["resources"] = [tb] - - get_tb = aiplatform.Tensorboard(tb.resource_name) - - assert tb.resource_name == get_tb.resource_name - - list_tb = aiplatform.Tensorboard.list() - - assert len(list_tb) > 0 + list_searched_features = featurestores.Featurestore.search_features() + assert len(list_searched_features) >= 0 diff --git a/tests/unit/aiplatform/test_featurestores.py b/tests/unit/aiplatform/test_featurestores.py index 95736f0748..bc02ed3eb8 100644 --- a/tests/unit/aiplatform/test_featurestores.py +++ b/tests/unit/aiplatform/test_featurestores.py @@ -356,7 +356,7 @@ def test_validate_and_get_featurestore_resource_id(self, featurestore_name: str) ) ) - def test_validate_and_get_featurestore_resource_ids_with_raise(self,): + def test_validate_and_get_featurestore_resource_id_with_raise(self,): with pytest.raises(ValueError): featurestore_utils.validate_and_get_featurestore_resource_id( featurestore_name=_TEST_FEATURESTORE_INVALID