allow_alias enum option is not respected

[busunkim96]

googleapis/python-recommendations-ai#14

IN_STOCK and STOCK_STATE_UNSPECIFIED both have a value of 0, without specifying allow_alias=True. This is causing deployment errors with protobuf.

The workaround is to specify no binary in requirements.txt:

protobuf==3.13.0 --no-binary=protobuf

https://github.com/googleapis/python-recommendations-ai/blob/90a06d1edb5b72403c6e039f99c90d1bdeef3337/google/cloud/recommendationengine_v1beta1/types/catalog.py#L167

Error

TypeError: Couldn't build proto file into descriptor pool!
Invalid proto descriptor for file "google/cloud/recommendationengine_v1beta1/types/catalog.proto":
google.cloud.recommendationengine.v1beta1.ProductCatalogItem.StockState: 
"google.cloud.recommendationengine.v1beta1.ProductCatalogItem.IN_STOCK" uses the same enum value as
"google.cloud.recommendationengine.v1beta1.ProductCatalogItem.STOCK_STATE_UNSPECIFIED". If this is
intended, set 'option allow_alias = true;' to the enum definition.

Docs
https://developers.google.com/protocol-buffers/docs/proto3

Protos: https://github.com/googleapis/googleapis/blob/9db36e1646684fc12657d735d9a388df3d5316e4/google/cloud/recommendationengine/v1beta1/catalog.proto#L133-L150

[busunkim96]

I attempted to re-generate the recommendations ai library and the generated unit tests no longer pass.

googleapis/python-recommendations-ai#18

EDIT:

It is also impacting websecurityscanner: googleapis/python-websecurityscanner#30

At the moment there are four APIs that use this option. Two of them are already published and the other two are likely to be published in 2021.

https://github.com/googleapis/googleapis/search?q=allow_alias

• appengine
• websecurityscanner
• recommendationengine
• storage