Skip to content
This repository has been archived by the owner on Dec 19, 2023. It is now read-only.

fix: move region tag to encompass catch #320

Merged
merged 6 commits into from Dec 30, 2019
Merged

Conversation

leahecole
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 30, 2019
@leahecole
Copy link
Contributor Author

ping me for buganizer bug if you want

@codecov
Copy link

codecov bot commented Dec 30, 2019

Codecov Report

Merging #320 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #320   +/-   ##
=======================================
  Coverage   52.78%   52.78%           
=======================================
  Files           7        7           
  Lines        1508     1508           
  Branches       53       53           
=======================================
  Hits          796      796           
  Misses        710      710           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcf1bb6...d94cd1a. Read the comment docs.

Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've usually kept the main().catch(console.error); out of the samples, I think if we moved to @fhinkel's suggestion of having an inner async function, so that async/await works as expected in samples, it would eliminate this need -- we'd then move the region tag inside the outer main method.

@leahecole
Copy link
Contributor Author

I'll make that change and update the PR accordingly

@leahecole
Copy link
Contributor Author

I have no idea how a bunch of stuff became lowercase but I'll revert all of those things now

@leahecole leahecole merged commit 988c5f5 into master Dec 30, 2019
@leahecole leahecole deleted the fix_quickstart_regiontag branch December 30, 2019 23:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants