Initial CRC-32C is not an integer

[m-spyratos]

Environment details

• OS: MacOS Mojave 10.14.6
• Node.js version: 10.16.3
• npm version: 6.9.0
• @google-cloud/storage version: 3.4.0
• fast-crc32c version: 2.0.0

Steps to reproduce

1. Install latest @google-cloud/storage (version above)
2. Install latest fast-crc32c (version above)
3. Try to upload a file to a bucket using file.save().

This is an example of my actual upload code:

await myBucket
    .file('myFile')
    .save(Buffer.from('iVBORw0KGgoAAAANSUhEUgAAAAUAAAAFCAYAAACNbyblAAAAHElEQVQI12P4//8/w38GIAXDIBKE0DHxgljNBAAO9TXL0Y4OHwAAAABJRU5ErkJggg==', 'base64'), {
        public: true
    });

Expected:

To save the file to provided bucket.

Actual:

Fails with Error: Initial CRC-32C is not an integer!
Same happens with setting resumable option: resumable: false.

[stephenplusplus]

Thanks for reporting! Could you run a quick npm ls | grep "hash-stream-validation"?

[m-spyratos]

Sure!

│ ├─┬ hash-stream-validation@0.2.1
│ │ ├── hash-stream-validation@0.2.1 deduped

[stephenplusplus]

Thank you! That's one patch away from the latest version, 0.2.2. Would you do a rm -rf node_modules && npm install to see if you pick that up? If not, you should be able to just manually install it.

In any case, if you're able to try that version and the problem goes away, we can bump our dependency from this library as the final fix. 🤞

[m-spyratos]

Ok I just noticed that firebase-admin uses hash-stream-validation and doesn't use the ^:

"hash-stream-validation": "0.2.1"

I guess this is what causes the issue?
Let me try quickly and I'll get back to you.

[m-spyratos]

Upgraded firebase-admin to latest which doesn't even include a hash-stream-validation version. Now only @google-cloud/storage loads it, but still the version shows up as 0.2.1 for some reason.

[m-spyratos]

I manually installed hash-stream-validation v0.2.2 and I can confirm now it works fine.
Bumping the dependency would be great!

[stephenplusplus]

Well that's good news! PR sent: #884 -- I'll let you know when it ships to a release so you can remove your manual override.

[m-spyratos]

Thank you @stephenplusplus !

[stephenplusplus]

@m-spyratos @google-cloud/storage@4.0.0 is out with this fix!