fix!: allow leading slashes in file name

[brianzinn]

I am integrating with Google storage and the files already have a leading /. It is not possible with this package to load them. I am doing something like this now to be able to load files:

const storagePath: string = '/file.png';
const file = await storage
      .bucket(bucketName)
      .file(storagePath);

// here file.name === 'file.png', but it needs to be '/file.png' to load an existing file.

 // https://github.com/googleapis/google-cloud-node/pull/2269
 file.name = storagePath;
 file.id = encodeURIComponent(storagePath);

I went this way to make it backwards compatible, but otherwise I can update the regex to take just one /, although that may be a breaking change for some clients.

Fixes #<issue_number_goes_here> (it's a good idea to open an issue first for discussion)

• Tests and linter pass
• Code coverage does not decrease (if any source code was changed)
• Appropriate docs were updated (if necessary)

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[brianzinn]

@googlebot I signed it!

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[brianzinn]

header-check is failing with this:

src/file.ts is missing a valid copyright line.
test/file.ts is missing a valid copyright line.

Both of those files have existing and unchanged copyrights...

[stephenplusplus]

Thank you for digging into this and offering a fix! Having another chance to look at this after a couple of years (googleapis/google-cloud-node#2269), I think we might have taken the wrong approach earlier. Since /blah.jpg is a valid file name, as much as //blah.jpg, I think we should remove our slash-stripping behavior completely. The input should not be touched, and we should keep the original file name. What do you think?

[brianzinn]

@stephenplusplus I can easily update the PR. I was mainly concerned with backwards compatibility. Some people upgrading versions may be unable to retrieve previous storage without changing code (or end up with storage in both forms). Note that rolling back will also fix getFiles(). Shall I remove the slash stripping completely?

[stephenplusplus]

I think we should remove it, yeah. Without worrying about backward compatibility (we can bump the major), would that be the most expected behavior from our library?

[brianzinn]

I'll fix PR today. Good idea to bump version.

[codecov]

Codecov Report

Merging #820 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #820      +/-   ##
==========================================
- Coverage   95.36%   95.36%   -0.01%     
==========================================
  Files          11       11              
  Lines        1231     1230       -1     
  Branches      307      307              
==========================================
- Hits         1174     1173       -1     
  Misses         29       29              
  Partials       28       28

Impacted Files	Coverage Δ
src/file.ts	98.2% <ø> (-0.01%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96a7fc2...b258e05. Read the comment docs.

[brianzinn]

For me the latest PR matches the expected behavior from your library. Let me know if I can make any additional changes or help out. Good idea to bump major version due to the nature of the change. Cheers.

[stephenplusplus]

@bcoe @jkwlui is this a good time to merge this, with the breaking change?