Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started to see typescript compilation failed overnight:
There hasn't been releases to
@types/nock
,typescript
orgts
. Sothis is a temporary fix to unblock releasing while we figure out why.
Update
Turns out starting at nock@11.1.0, they shipped their own typescript definition in the package. The types assumed the downstream library uses
esModuleInterop
soimport * as nock from 'nock'
failed typescript compilation, whileimport nock from 'nock'
successfully compiled, but failed at runtime.