Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): upgrade @google-cloud/common version to show original error message #795

Merged
merged 4 commits into from Aug 9, 2019

Conversation

jiren
Copy link
Member

@jiren jiren commented Aug 5, 2019

Upgraded @google-cloud/common has added original error message with of JSON parsing failure.

  • To check original message is propagating to api response, added system test case for non JSON response body. ( metadata size is too large)

Fixes #170

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 5, 2019
@jiren jiren changed the title Version up for gc common to show original error message Upgraded @google-cloud/common version to show original error message Aug 5, 2019
- Added system test case for non json response error
@codecov
Copy link

codecov bot commented Aug 6, 2019

Codecov Report

Merging #795 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #795   +/-   ##
=======================================
  Coverage   94.96%   94.96%           
=======================================
  Files          10       10           
  Lines        1152     1152           
  Branches      288      288           
=======================================
  Hits         1094     1094           
  Misses         30       30           
  Partials       28       28

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8ceb78...d3ba284. Read the comment docs.

@jiren jiren changed the title Upgraded @google-cloud/common version to show original error message fix(dips): upgrade @google-cloud/common version to show original error message Aug 9, 2019
@jiren jiren changed the title fix(dips): upgrade @google-cloud/common version to show original error message fix(deps): upgrade @google-cloud/common version to show original error message Aug 9, 2019
@stephenplusplus stephenplusplus merged commit ea63cbe into googleapis:master Aug 9, 2019
@jiren jiren deleted the error_message_170 branch August 9, 2019 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error message in Node.js console is not the orignial error message
4 participants