Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(typescript): make SetLabelOptions optional #766

Merged
merged 4 commits into from Jul 16, 2019
Merged

fix(typescript): make SetLabelOptions optional #766

merged 4 commits into from Jul 16, 2019

Conversation

callmehiphop
Copy link
Contributor

@callmehiphop callmehiphop commented Jul 12, 2019 •
edited

test(bucket): location type system tests
docs(bucket): add verbiage about deprecated storage classes

Closes #732

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 12, 2019
@callmehiphop
Copy link
Contributor Author

@JesseLovelace as mentioned previously, no code change was required. So I've added some e2e tests to make sure the field was populated correctly.

JesseLovelace
JesseLovelace reviewed Jul 12, 2019
View reviewed changes
Copy link
Contributor

@JesseLovelace JesseLovelace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update the documentation at 2755 to specify that multi_regional and regional are now legacy/deprecated?

JustinBeckwith
JustinBeckwith approved these changes Jul 14, 2019
View reviewed changes
src/bucket.ts Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 15, 2019 •
edited

Codecov Report

Merging #766 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #766   +/-   ##
=======================================
  Coverage   96.55%   96.55%           
=======================================
  Files           9        9           
  Lines        1132     1132           
  Branches      287      287           
=======================================
  Hits         1093     1093           
  Misses         11       11           
  Partials       28       28
Impacted Files Coverage Δ
src/bucket.ts 92.68% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99e3b17...6fa82c4. Read the comment docs.

@callmehiphop callmehiphop changed the title test(bucket): location type system tests fix(typescript): make SetLabelOptions optional Jul 15, 2019
@callmehiphop callmehiphop added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 16, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 16, 2019
@callmehiphop callmehiphop merged commit 4336882 into googleapis:master Jul 16, 2019
@callmehiphop callmehiphop deleted the location-type branch July 16, 2019 16:16
@odeke-em odeke-em mentioned this pull request Jul 29, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcoe bcoe bcoe approved these changes

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

@jkwlui jkwlui jkwlui approved these changes

@JesseLovelace JesseLovelace JesseLovelace approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Storage: Support bucket.location_type
7 participants
@callmehiphop @bcoe @JustinBeckwith @jkwlui @JesseLovelace @googlebot @kokoro-team