Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetFilesResponse not fully typed #2284

Open
jared-jewitt opened this issue Aug 23, 2023 · 1 comment
Open

GetFilesResponse not fully typed #2284

jared-jewitt opened this issue Aug 23, 2023 · 1 comment
Labels
api: storage Issues related to the googleapis/nodejs-storage API. next major: breaking change this is a change that we should wait to bundle into the next major version priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@jared-jewitt
Copy link

It would be nice to have more type definition for GetFilesResponse -- particularly for the second and third items in the tuple type.

The SDK docs don't specify that these two items exist; the only place I could find documentation about the response body (third item in the tuple) was the docs on the console.

Environment details

  • OS: MacOS Ventura 13.4.1
  • Node.js version: 16.10.0
  • npm version: 7.24.0
  • @google-cloud/storage version: 7.0.1

Steps to reproduce

  1. Observe the type definition for GetFilesResponse in node_modules
  2. Note that the second and third items in the tuple type are not fully typed
@jared-jewitt jared-jewitt added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Aug 23, 2023
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/nodejs-storage API. label Aug 23, 2023
@ddelgrosso1 ddelgrosso1 added priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Aug 24, 2023
@ddelgrosso1
Copy link
Contributor

Hi @jared-jewitt thanks for opening an issue. We are in the process of trying to cleanup a lot of these interfaces that weren't originally typed well / typed at all. Unfortunately, since more strongly typing things is potentially a breaking change this is something we will likely have to wait to release until the next major version.

@ddelgrosso1 ddelgrosso1 added the next major: breaking change this is a change that we should wait to bundle into the next major version label Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/nodejs-storage API. next major: breaking change this is a change that we should wait to bundle into the next major version priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jared-jewitt @ddelgrosso1