Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow retries of metadatata operations in system tests #1568

Merged
merged 2 commits into from Aug 26, 2021
Merged

fix: allow retries of metadatata operations in system tests #1568

merged 2 commits into from Aug 26, 2021

Conversation

ddelgrosso1
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 馃

@ddelgrosso1 ddelgrosso1 requested a review from a team August 26, 2021 23:03
@ddelgrosso1 ddelgrosso1 requested a review from a team as a code owner August 26, 2021 23:03
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 26, 2021
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/nodejs-storage API. label Aug 26, 2021
@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 26, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 26, 2021
@ddelgrosso1
Copy link
Contributor Author

Fixes #1563
Fixes #1564
Fixes #1565

@shaffeeullah shaffeeullah merged commit 9398566 into googleapis:master Aug 26, 2021
@ddelgrosso1 ddelgrosso1 deleted the fix-flaky-system-tests branch August 26, 2021 23:27
@shaffeeullah shaffeeullah mentioned this pull request Aug 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaffeeullah shaffeeullah shaffeeullah approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/nodejs-storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ddelgrosso1 @shaffeeullah