Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: retries for conditionally idempotent operations #1561

Merged
merged 3 commits into from Aug 26, 2021
Merged

feat: retries for conditionally idempotent operations #1561

merged 3 commits into from Aug 26, 2021

Conversation

ddelgrosso1
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@ddelgrosso1
feat: handle retries for conditionally idempotent bucket ops (#1543)
7668f4c 
* feat: handle retries for conditionally idempotent bucket ops

* remove accidental import

* feedback, add tests

* remove accidental import

* linter fixes
@ddelgrosso1
feat: disable retries for conditionally idempotent file operations (#…
5c8d87b 
…1554)

* feat: disable retries for conditionally idempotent file operations

* add IdempotencyStrategy flag to control rerying conditionally idempotent operations
@ddelgrosso1 ddelgrosso1 requested a review from a team August 26, 2021 17:32
@ddelgrosso1 ddelgrosso1 requested a review from a team as a code owner August 26, 2021 17:32
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 26, 2021
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/nodejs-storage API. label Aug 26, 2021
@ddelgrosso1 ddelgrosso1 added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Aug 26, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 26, 2021
@ddelgrosso1 ddelgrosso1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 26, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 26, 2021
@ddelgrosso1 ddelgrosso1 merged commit 653f4b4 into master Aug 26, 2021
@ddelgrosso1 ddelgrosso1 deleted the retries-conditionally-idempotent branch August 26, 2021 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaffeeullah shaffeeullah shaffeeullah approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/nodejs-storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ddelgrosso1 @shaffeeullah @yoshi-kokoro