Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): link to correct gaxOptions docs #999

Merged
merged 1 commit into from May 19, 2020

Conversation

stephenplusplus
Copy link
Contributor

Fixes #990

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 13, 2020
@codecov
Copy link

codecov bot commented May 13, 2020

Codecov Report

Merging #999 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #999      +/-   ##
==========================================
+ Coverage   95.17%   95.21%   +0.03%     
==========================================
  Files          22       22              
  Lines       10615    10615              
  Branches      466      509      +43     
==========================================
+ Hits        10103    10107       +4     
+ Misses        509      505       -4     
  Partials        3        3              
Impacted Files Coverage Δ
src/iam.ts 100.00% <100.00%> (ø)
src/pubsub.ts 99.50% <100.00%> (+0.16%) ⬆️
src/subscription.ts 100.00% <100.00%> (ø)
src/topic.ts 98.63% <100.00%> (ø)
src/subscriber.ts 99.79% <0.00%> (+0.20%) ⬆️
src/message-stream.ts 98.70% <0.00%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b242a3...65b7d32. Read the comment docs.

Copy link
Collaborator

@feywind feywind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why we've got all these manually specified links in the source :S ... seems like something we ought to fix. But thank you for putting in this update!

@feywind feywind merged commit 312e318 into googleapis:master May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken link for gaxOpts
3 participants