Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set publish timeouts to be consistent with desired values #1398

Closed
feywind opened this issue Sep 23, 2021 · 0 comments · Fixed by #1399
Closed

Set publish timeouts to be consistent with desired values #1398

feywind opened this issue Sep 23, 2021 · 0 comments · Fixed by #1399
Assignees
@feywind
Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@feywind
Copy link
Collaborator

feywind commented Sep 23, 2021

This adjusts the Node Pub/Sub retry timeout defaults to match the desired values found in other libraries, e.g.:

googleapis/java-pubsub#820
@feywind feywind added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: pubsub Issues related to the googleapis/nodejs-pubsub API. labels Sep 23, 2021
@feywind feywind self-assigned this Sep 23, 2021
feywind added a commit to feywind/nodejs-pubsub that referenced this issue Sep 23, 2021
@feywind
fix: update default RPC retry timeouts to match other languages
849e6c3 
Fixes: googleapis#1398
@feywind feywind mentioned this issue Sep 23, 2021
Merged
feywind added a commit that referenced this issue Sep 23, 2021
@feywind
fix: update default RPC retry timeouts to match other languages (#1399)
8c1afee 
Fixes: #1398
@feywind feywind mentioned this issue Nov 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@feywind feywind

Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: update default RPC retry timeouts to match other languages feywind/nodejs-pubsub
1 participant
@feywind